Skip to content

Fixes theme header logo and icon upload#18851

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
wiardvanrij:logo-favicon-fix
Oct 31, 2018
Merged

Fixes theme header logo and icon upload#18851
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
wiardvanrij:logo-favicon-fix

Conversation

@wiardvanrij
Copy link
Copy Markdown
Contributor

@wiardvanrij wiardvanrij commented Oct 26, 2018 •
edited
Loading

Description (*)

With the change of "fileuploader" to "imageuploader" the correct formElement was not updated to match the new "imageuploader".

Fixed Issues (if relevant)

  1. Unable to upload Logo, Magento 2.3.0 Beta18 #18688: Unable to upload Logo, Magento 2.3.0 Beta18
  2. ...

Manual testing scenarios (*)

  1. Use magento2.3 development branche
  2. Content -> Design -> Configuration -> edit any Default Store View
  3. Other Settings -> Header -> try to upload a favicon or logo

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 26, 2018

Hi @wiardvanrij. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Copy Markdown
Contributor

rogyar commented Oct 27, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 27, 2018

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@rogyar rogyar self-assigned this Oct 27, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 27, 2018

Hi @rogyar, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18851-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Copy Markdown
Contributor

rogyar commented Oct 27, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 27, 2018

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 27, 2018

Hi @rogyar, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18851//admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 27, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 27, 2018

@wiardvanrij thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@wiardvanrij
Copy link
Copy Markdown
Contributor Author

wiardvanrij commented Oct 27, 2018

Anyone knows why travis did not run properly?

@rogyar
Copy link
Copy Markdown
Contributor

rogyar commented Oct 28, 2018

The issue with Travis will be fixed soon

@okorshenko okorshenko mentioned this pull request Oct 31, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit ba69bfe into magento:2.3-develop Oct 31, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 31, 2018
@slavvka
ENGCOM-3296: Fixes theme header logo and icon upload #18851
c96b8af
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 31, 2018

Hi @wiardvanrij. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@ghost ghost mentioned this pull request Dec 5, 2018
Closed
@ekisaj
Copy link
Copy Markdown

ekisaj commented Dec 18, 2018

Hello, I am facing the same problem, I cannot upload logo/favicon image. I am using Magento 2.3.0 and php 7.2.8. Anyone with a fix?

@ghost ghost mentioned this pull request Dec 19, 2018
Closed
@chaplynsky chaplynsky mentioned this pull request Jan 6, 2019
Closed
@davidverholen davidverholen mentioned this pull request Jan 6, 2019
Closed
@ghost ghost mentioned this pull request Jan 18, 2019
Closed
@webusat
Copy link
Copy Markdown

webusat commented Feb 1, 2019 •
edited
Loading

I have the same problem with a fresh install of 2.3 trying to change the Transactional Email Logo. I click Upload to upload the logo image, choose the image and I get a running circle for a second and nothing is ever added. No logo image is displayed in the backend at all and the image in the email is still the default Magento logo. I can confirm that changing the core design_config_form.xml (not recommended) @valikvali does work.

@ghost ghost mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rogyar rogyar

Labels

Area: Frontend Award: bug fix Component: Theme Partner: Redkiwi partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.